daemon@TELECOM.MIT.EDU (jb%cs.brown.edu@RELAY.CS.NET) Fri Jul 29 13:25:36 1988 From: jb%cs.brown.edu@RELAY.CS.NET To: kerberos@ATHENA.MIT.EDU I have only gotten as far as reading the documentation and compiling the code of the beta test release and have not started running it yet. Here are some comments about what I have seen so far. First, the manual pages make too much reference to the Athena environment. If someone outside of MIT is told there system is running kerberos and types man kerberos, the paragraph has the sentence "All Athena timesharing machines and public workstations support Kerberos." What does this fact have to do with anyone else using the software. Other comments like this and about other software at Athena are also included. The manual pages should be complete in themselves and not reference other software that is not running on the machine. Next, I used a compiler that effectively runs lint on the code as well. I had more lines of lint style warning from the compiler than commands executed by make. Rcs ids I won't argue about (this was only about half of the errors though), but there were lots of unused variables. Also included were many statics that were not initialized before use. Finally, skimming the code for rsh and rlogin leads to some interesting discoveries. First, the "-n" flag has different meanings between the two programs. In rsh it means disconnect stdin from the terminal and in rlogin it means allow escape character (I think). On a similar note, how about manual pages which describe the new options in the bsd applications. Half of the mods were made for various reasons at Athena which are not related kerberos. Jim